alternative asdf in fits implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exploits the lazy loading of NDArrayType objects to implement asdf in fits. After the yaml is parsed and tree is loaded, the tree is modified and each NDArrayType is replaced with the corresponding array from the hdulist.
|
Running regression tests with this branch: |
|
Those tests crashed and burned because of an unrelated failure: spacetelescope/jwst#7435 Will rerun when things settle. |
|
I reran the jwst regression tests now that the unrelated issue was fixed. The updated run passed with no errors: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversation in PR spacetelescope#110
exploits the lazy loading of NDArrayType objects
to implement asdf in fits. After the yaml is parsed and tree is loaded, the tree is modified and each
NDArrayType is replaced with the corresponding array from the hdulist.